Rename to reduce top-level interface and type alias #2250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from json_options to JSON::options
from json_generator to JSON::generator
from json_parser to JSON::parser
from json_state to JSON::state
from _JsonReadableIO to JSON::_ReadableIO from _JsonRead to JSON::_Read
from _JsonToWritableIO to JSON::_WritableIO from _JsonWrite to JSON::_Write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type aliases and interfaces cannot overlap.
Therefore, if they are defined at the top level, they affect all RBS files being loaded, so caution is required when using them.
I moved the four interfaces and four type aliases defined in
jsonunder theJSONmodule.This change is incompatible, and any type definitions already using these signatures will need to be updated.
However, in the scope of my investigation, I did not find any usage of these.
As for
_ToJson, it is also used in the RBS library, so I believe it is fine to leave it as it is.